Make Angular manifest parsing more robust #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuangwang
requested review from
blidd-google,
jamesdaniels,
leoortizz,
sjjj986,
taeold and
tonyjhuang
as code owners
jamesdaniels
requested changes
Mar 12, 2025
Collaborator
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM, I'd encourage some test coverage though. Would be nice if we can get the e2e test to trigger this behavior somehow.
jamesdaniels
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the bug where people were occasionally the manifest file would add new line characters, breaking the parsing #307